Add USD value banner on tokens page #5934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhabib
approved these changes
Dec 6, 2024
yhabib
pushed a commit
that referenced
this pull request
Dec 9, 2024
# Motivation Using the banner component from #5932 on the tokens page. # Changes 1. Calculate the sum of USD values in `frontend/src/lib/pages/Tokens.svelte`. 2. Add `UsdValueBanner` if `ENABLE_USD_VALUES` is enabled. # Tests 1. Unit tests added. 2. Tested manually at https://qsgjb-riaaa-aaaaa-aaaga-cai.dskloet-ingress.devenv.dfinity.network/ # Todos - [ ] Add entry to changelog (if necessary). not yet
1 task
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 10, 2024
# Motivation #5934 added the USD value banner on the tokens page. We want the same banner on the ICP accounts page. # Changes 1. Move function to add up USD balances to utils. 2. Add banner to `NnsAccounts` component. # Tests 1. Unit tests added. 2. Tested manually at https://qsgjb-riaaa-aaaaa-aaaga-cai.dskloet-ingress.devenv.dfinity.network/accounts/?u=qsgjb-riaaa-aaaaa-aaaga-cai # Todos - [ ] Add entry to changelog (if necessary). not yet
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 10, 2024
# Motivation #5934 added the USD value banner on the tokens page. We want the same banner on the ICP accounts page. # Changes 1. Move function to add up USD balances to utils. 2. Add banner to `NnsAccounts` component. # Tests 1. Unit tests added. 2. Tested manually at https://qsgjb-riaaa-aaaaa-aaaga-cai.dskloet-ingress.devenv.dfinity.network/accounts/?u=qsgjb-riaaa-aaaaa-aaaga-cai # Todos - [ ] Add entry to changelog (if necessary). not yet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Using the banner component from #5932 on the tokens page.
Changes
frontend/src/lib/pages/Tokens.svelte.UsdValueBannerifENABLE_USD_VALUESis enabled.Tests
Todos
not yet