Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NNS1-3486: adds ReportingTransactions component to orchestrate dateRange #6026

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

yhabib
Copy link
Contributor

@yhabib yhabib commented Dec 17, 2024

Motivation

Users can filter their export by choosing one of three options: all, this year, or last year.

A follow up PR, will hooked both ReportingRangeDateSelector and ReportingTransactionsButton to download transactions for the selected period of time.

Changes

  • Adds a new component called ReportingTransactions to orchestrate downloading transactions for a period

Tests

  • Not necessary

Todos

  • Add entry to changelog (if necessary).
    Not necessary

Prev. PR: #6019

Base automatically changed from NNS1-3486/range-component to main December 17, 2024 09:28
@yhabib yhabib force-pushed the NNS1-3486/reporting-component branch from 8481297 to 5cfbab5 Compare December 17, 2024 09:38
@yhabib yhabib marked this pull request as ready for review December 17, 2024 10:11
@yhabib yhabib requested a review from a team as a code owner December 17, 2024 10:11
@yhabib yhabib force-pushed the NNS1-3486/reporting-component branch from 89b6172 to f706c63 Compare December 17, 2024 10:38
@yhabib yhabib requested a review from dskloetd December 17, 2024 10:39
@yhabib yhabib added this pull request to the merge queue Dec 17, 2024
Merged via the queue into main with commit 35cb27c Dec 17, 2024
45 of 62 checks passed
@yhabib yhabib deleted the NNS1-3486/reporting-component branch December 17, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants