-
Notifications
You must be signed in to change notification settings - Fork 25
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore(frontend): bump tailwindcss to v4 (#4665)
# Motivation We want to bump `tailwindcss` to v4. However [the migration tool does not support SASS files](tailwindlabs/tailwindcss#15716). # Workaround We changed all the `.scss` files to a copy in `.css` and use the migration tool, and then reverted. Same thing with the language in the `<style>` tag of Svelte components. Then we added a few manual tweaks anyway. # Disclaimer Since a part of the PR was a manual process, it may very well be that I missed something or there is some error in migration. # Note Apparently `prettier-plugin-tailwindcss` was bumped too, so a few changes happened in the sorting order of the tailwind classes too. That is the reason for this many files changed in this PR, since we have an auto-formatter. Furthermore, it seems that [a few classes will require a Vite update to work properly](vitejs/vite#18974). For example `space-x-*` and `space-y-*`. # Changes - The migration tool: - installed `tailwindcss` v4; - changed `postcss.config`; - migrated the tailwind classes that required migration (see [upgrade guide](https://tailwindcss.com/docs/upgrade-guide)); - correctly changed `global.css` (that we reverted to `global.scss` after). - A few changes were missing, and we did it manually: - The `Hero` gradient does not need a `via-` color anymore, it can changed to `from-`. - The util `@screen foo` is deprecated and should be replaced with `@media (width >= theme(--breakpoint-foo))` (see [codebase of tailwindcss migration](https://github.com/tailwindlabs/tailwindcss/blob/121cf6bd807a35ad9814dd5444eeb3594601fff8/packages/%40tailwindcss-upgrade/src/codemods/migrate-media-screen.test.ts)). - It is [suggested](https://tailwindcss.com/docs/upgrade-guide#using-vite) to install and add `@tailwindcss/vite` in `vite` (and `vitest`) configs; - Move `@include meta.load-css(...)` inside `@layer base {...}` (suggestion in [tailwindcss discussion](tailwindlabs/tailwindcss#16421)). - We create another branch to make the changes manually following the [upgrade guide](https://tailwindcss.com/docs/upgrade-guide) and they matched: - #4666 # Tests There is not much test to help us, apart update the E2E snapshots and manual navigation in local replica: https://github.com/user-attachments/assets/d0ae2e36-7fff-4ff8-8829-3c93e900650a --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
- Loading branch information
1 parent
85b6e46
commit 97fae91
Showing
201 changed files
with
878 additions
and
841 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
+6.07 KB
(100%)
...modal.spec.ts-snapshots/should-display-about-why-oisy-modal-1-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+3.67 KB
(100%)
...spec.ts-snapshots/should-display-about-why-oisy-modal-1-Google-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-6.16 KB
(92%)
...modal.spec.ts-snapshots/should-display-about-why-oisy-modal-1-Pixel-7-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+9.18 KB
(100%)
...modal.spec.ts-snapshots/should-display-about-why-oisy-modal-1-Safari-darwin.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-5.63 KB
(94%)
...al.spec.ts-snapshots/should-display-about-why-oisy-modal-1-iPhone-SE-darwin.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-2.51 KB
(98%)
...ctivity-page.spec.ts-snapshots/should-display-activity-page-1-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-1.71 KB
(98%)
...y-page.spec.ts-snapshots/should-display-activity-page-1-Google-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.82 KB
(100%)
...ctivity-page.spec.ts-snapshots/should-display-activity-page-1-Pixel-7-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-2.68 KB
(98%)
...ctivity-page.spec.ts-snapshots/should-display-activity-page-1-Safari-darwin.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+4.07 KB
(100%)
...vity-page.spec.ts-snapshots/should-display-activity-page-1-iPhone-SE-darwin.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-6.07 KB
(99%)
...xplorer-page.spec.ts-snapshots/should-display-explorer-page-1-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-4.48 KB
(98%)
...r-page.spec.ts-snapshots/should-display-explorer-page-1-Google-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-6.62 KB
(98%)
...xplorer-page.spec.ts-snapshots/should-display-explorer-page-1-Safari-darwin.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-7.54 KB
(95%)
...d-to-home-if-not-network-is-provided-to-access-transactions-1-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-5.51 KB
(96%)
...ome-if-not-network-is-provided-to-access-transactions-1-Google-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+5.45 KB
(110%)
...d-to-home-if-not-network-is-provided-to-access-transactions-1-Pixel-7-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-7.39 KB
(97%)
...d-to-home-if-not-network-is-provided-to-access-transactions-1-Safari-darwin.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+6.59 KB
(110%)
...o-home-if-not-network-is-provided-to-access-transactions-1-iPhone-SE-darwin.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-7.54 KB
(95%)
...pec.ts-snapshots/should-display-homepage-in-logged-in-state-1-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-4.69 KB
(96%)
...-snapshots/should-display-homepage-in-logged-in-state-1-Google-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+5.45 KB
(110%)
...pec.ts-snapshots/should-display-homepage-in-logged-in-state-1-Pixel-7-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-7.39 KB
(97%)
...pec.ts-snapshots/should-display-homepage-in-logged-in-state-1-Safari-darwin.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+6.59 KB
(110%)
....ts-snapshots/should-display-homepage-in-logged-in-state-1-iPhone-SE-darwin.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-3.8 KB
(99%)
...ec.ts-snapshots/should-display-homepage-in-logged-out-state-1-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-1.64 KB
(99%)
...snapshots/should-display-homepage-in-logged-out-state-1-Google-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-4.17 KB
(99%)
...ec.ts-snapshots/should-display-homepage-in-logged-out-state-1-Safari-darwin.png
Oops, something went wrong.
Binary file modified
BIN
-225 Bytes
(100%)
...ens.spec.ts-snapshots/should-enable-and-disable-ERC20-token-1-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
-351 Bytes
(100%)
...ec.ts-snapshots/should-enable-and-disable-ERC20-token-1-Google-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-238 Bytes
(100%)
...ens.spec.ts-snapshots/should-enable-and-disable-ERC20-token-1-Pixel-7-linux.png
Oops, something went wrong.
Binary file modified
BIN
+268 Bytes
(100%)
...ens.spec.ts-snapshots/should-enable-and-disable-ERC20-token-1-Safari-darwin.png
Oops, something went wrong.
Binary file modified
BIN
-157 Bytes
(100%)
...napshots/should-enable-and-disable-SepoliaERC20-token-1-Google-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-235 Bytes
(100%)
...c.ts-snapshots/should-enable-and-disable-SepoliaERC20-token-1-Pixel-7-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.15 KB
(100%)
...modal.spec.ts-snapshots/should-display-receive-tokens-modal-1-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+2.67 KB
(100%)
...spec.ts-snapshots/should-display-receive-tokens-modal-1-Google-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
+171 Bytes
(100%)
...modal.spec.ts-snapshots/should-display-receive-tokens-modal-1-Pixel-7-linux.png
Oops, something went wrong.
Binary file modified
BIN
+174 Bytes
(100%)
...modal.spec.ts-snapshots/should-display-receive-tokens-modal-1-Safari-darwin.png
Oops, something went wrong.
Binary file modified
BIN
+227 Bytes
(100%)
...al.spec.ts-snapshots/should-display-receive-tokens-modal-1-iPhone-SE-darwin.png
Oops, something went wrong.
Binary file modified
BIN
-6.57 KB
(95%)
...end-and-receive-flow.spec.ts-snapshots/receive-and-send-ICP-1-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
-4.79 KB
(96%)
...d-receive-flow.spec.ts-snapshots/receive-and-send-ICP-1-Google-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-7.2 KB
(96%)
...end-and-receive-flow.spec.ts-snapshots/receive-and-send-ICP-1-Safari-darwin.png
Oops, something went wrong.
Binary file modified
BIN
-6.52 KB
(95%)
...ettings-page.spec.ts-snapshots/should-display-settings-page-1-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
-4.6 KB
(96%)
...s-page.spec.ts-snapshots/should-display-settings-page-1-Google-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-6.55 KB
(96%)
...ettings-page.spec.ts-snapshots/should-display-settings-page-1-Safari-darwin.png
Oops, something went wrong.
Binary file modified
BIN
-6.45 KB
(95%)
...page.spec.ts-snapshots/should-display-BTC-transactions-page-1-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
-2.22 KB
(98%)
...pec.ts-snapshots/should-display-BTC-transactions-page-1-Google-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
+841 Bytes
(100%)
...page.spec.ts-snapshots/should-display-BTC-transactions-page-1-Pixel-7-linux.png
Oops, something went wrong.
Binary file modified
BIN
+3.38 KB
(100%)
...page.spec.ts-snapshots/should-display-BTC-transactions-page-1-Safari-darwin.png
Oops, something went wrong.
Binary file modified
BIN
+8.63 KB
(110%)
...e.spec.ts-snapshots/should-display-BTC-transactions-page-1-iPhone-SE-darwin.png
Oops, something went wrong.
Binary file modified
BIN
-3.68 KB
(97%)
...page.spec.ts-snapshots/should-display-ICP-transactions-page-1-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
-2.34 KB
(98%)
...pec.ts-snapshots/should-display-ICP-transactions-page-1-Google-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
+2.02 KB
(100%)
...page.spec.ts-snapshots/should-display-ICP-transactions-page-1-Pixel-7-linux.png
Oops, something went wrong.
Binary file modified
BIN
-4.76 KB
(98%)
...page.spec.ts-snapshots/should-display-ICP-transactions-page-1-Safari-darwin.png
Oops, something went wrong.
Binary file modified
BIN
+2.91 KB
(100%)
...e.spec.ts-snapshots/should-display-ICP-transactions-page-1-iPhone-SE-darwin.png
Oops, something went wrong.
Oops, something went wrong.