build(frontend): bump tailwind #4802
Merged
+74
−80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DenysKarmazynDFINITY
approved these changes
Feb 18, 2025
|
Indeed, it contains fixes so still better... |
AntonioVentilii
added a commit
that referenced
this pull request
Feb 28, 2025
# Motivation Given recent reproducibilities issues with bumping Tailwind v4 (see one of the fixes [here](#4802)), we include the CI that checks the frontend reproducibility in each PR, and on `main`. Furthermore, once this PR is merged, we will add the check among the compulsory ones to be able to merge any PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We detected reproducibility issue when building v0.24.0:
https://github.com/dfinity/oisy-wallet/actions/runs/13393064153
I'm unsure which of the two following Tailwind fix was the reason of the problem but, bumping Tailwind to latest version seems to resolve the problem.Tailwind v4.0.6 - Fix #16403~~- Revert change to no longer include theme variables that aren't used in compiled CSS ~~
Tailwind v4.0.7 - Fix #16414- Fix sorting of numeric utility suggestions when they have different magnitudesI lean towards to former though. I could have try v4.0.6 but, v4.0.7 contains interesting fixes anyway.It does not resolve the issue: https://github.com/dfinity/oisy-wallet/actions/runs/13395505962/job/37413394328
Changes
@tailwindcss/postcss,@tailwindcss/viteandtailwindcss.