Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(station)!: refactor asset related data models #357

Merged
merged 18 commits into from
Oct 4, 2024
Merged

feat(station)!: refactor asset related data models #357

merged 18 commits into from
Oct 4, 2024

Conversation

olaszakos
Copy link
Contributor

@olaszakos olaszakos commented Sep 26, 2024 •
edited
Loading

Disabled checks:

  • Frontend validation
  • Migration tests

@olaszakos olaszakos changed the base branch from main to multi-chain-support September 26, 2024 10:26
@olaszakos olaszakos changed the title feat!(station): refactor asset related data models feat(station)!: refactor asset related data models Oct 2, 2024
olaszakos and others added 8 commits October 2, 2024 15:10
@olaszakos
cargo fmt
3765907
@olaszakos
run dfx generate
9790526
@olaszakos
add address_format to AddressBookEntryDTO
15ebd30
@olaszakos
cleanup
1c94320
@olaszakos
persist canbench
d72fc70
@olaszakos
disable frontend checks
82a6b91
@mraszyk @olaszakos
chore(control-panel): upload station and upgrader separately (#342)
f3e9e24 
This PR refactors the `upload_canister_modules` of the control panel to
allow uploading the station and upgrader separately so that they don't
have to jointly fit into the ingress message size limit of 2MiB on
application subnets.
@olaszakos
run dfx generate
589be0c
@olaszakos olaszakos marked this pull request as ready for review October 3, 2024 10:30
@olaszakos olaszakos requested review from mraszyk and a team as code owners October 3, 2024 10:30
keplervital
keplervital approved these changes Oct 4, 2024
View reviewed changes
core/station/impl/src/core/metrics.rs Show resolved Hide resolved
core/station/impl/src/core/metrics.rs Show resolved Hide resolved
core/station/impl/src/errors/account.rs Outdated Show resolved Hide resolved
core/station/impl/src/factories/blockchains/internet_computer.rs Outdated Show resolved Hide resolved
core/station/impl/src/models/request_operation.rs Outdated Show resolved Hide resolved
core/station/impl/src/services/account.rs Outdated Show resolved Hide resolved
core/station/impl/src/services/account.rs Show resolved Hide resolved
core/station/impl/src/services/account.rs Show resolved Hide resolved
core/station/impl/src/services/system.rs Show resolved Hide resolved
tests/integration/src/migration_tests.rs Show resolved Hide resolved
@olaszakos olaszakos merged commit 8c31320 into multi-chain-support Oct 4, 2024
20 checks passed
@olaszakos olaszakos deleted the ORB-307-refactor-asset-related-data-models branch October 4, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keplervital keplervital keplervital approved these changes

@mraszyk mraszyk Awaiting requested review from mraszyk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@olaszakos @keplervital @mraszyk