Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(station)!: migrate to new model #408

Merged
merged 24 commits into from
Oct 31, 2024
Merged

feat(station)!: migrate to new model #408

merged 24 commits into from
Oct 31, 2024

Conversation

olaszakos
Copy link
Contributor

@olaszakos olaszakos commented Oct 26, 2024 •
edited
Loading

STATION

  1. create ICP asset and set up asset management permissions and policies
  2. migrate models:
    • Account
      • remove blockchain
      • remove address
      • remove standard
      • remove symbol
      • remove `decimals
      • remove balance
      • add seed
      • add assets
      • add addresses
    • Transfer
      • add from_asset
      • add with_standard
    • RequestOperation
      • EditAccount
        • add change_assets
      • TransferOperation
        • add asset
      • TransferOperationInput
        • add from_asset_id
        • add with_standard
      • AddAccountOperationInput
        • add assets
        • remove blockchain
        • remove standard
      • AddAddressBookEntryOperationInput
        • add address_format
    • AddressBookEntry
      • add address_format
  3. update integration tests
  4. add snapshot generation test

UPGRADER:

  1. migrate accounts support both old and new model
  2. update DR spec

@olaszakos olaszakos changed the base branch from main to multi-chain-support October 26, 2024 08:28
@olaszakos olaszakos marked this pull request as ready for review October 30, 2024 17:23
@olaszakos olaszakos requested review from mraszyk and a team as code owners October 30, 2024 17:23
olaszakos and others added 6 commits October 31, 2024 11:09
@olaszakos
fix lint
91c7a27
@olaszakos @keplervital
Update core/upgrader/api/spec.did
81895bd 
Co-authored-by: Kepler Vital <dev@keplervital.com>
@olaszakos @keplervital
Update core/upgrader/api/spec.did
20e69a5 
Co-authored-by: Kepler Vital <dev@keplervital.com>
@olaszakos @keplervital
Update core/upgrader/impl/src/services/disaster_recovery.rs
ada3cdb 
Co-authored-by: Kepler Vital <dev@keplervital.com>
@olaszakos @keplervital
Update tests/integration/src/migration_tests.rs
6a3a433 
Co-authored-by: Kepler Vital <dev@keplervital.com>
@olaszakos
Merge branch 'PEN-309-migrate-to-new-model' of github.com:dfinity/orb…
79f3997 
…it-wallet into PEN-309-migrate-to-new-model
keplervital
keplervital approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@keplervital keplervital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@olaszakos olaszakos merged commit ffbfad6 into multi-chain-support Oct 31, 2024
21 checks passed
@olaszakos olaszakos deleted the PEN-309-migrate-to-new-model branch October 31, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keplervital keplervital keplervital approved these changes

@mraszyk mraszyk Awaiting requested review from mraszyk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olaszakos @keplervital