feat(station): configurable station initialization #482
Conversation
…:dfinity/orbit into kepler/pen-411-configurable-station-init
| return Ordering::Less; | ||
| } | ||
| } | ||
| Ordering::Greater |
There was a problem hiding this comment.
I'm not sure this result leads to keeping the original order: shouldn't we compare the original indices here?
| print("Adding initial accounts"); | ||
| install_canister_handlers::set_initial_accounts(accounts, &init.assets, quorum) | ||
| let initial_user_count = init.users.len() as u16; | ||
| let quorum = calc_initial_quorum(initial_user_count, init.quorum); |
There was a problem hiding this comment.
Why is the quorum based on the number of all initial users (incl. non-admins)?
| max: u16::MAX as usize, | ||
| })?; | ||
| } | ||
|
|
||
| // adds the default admin group | ||
| init_canister_sync_handlers::add_initial_groups(); | ||
| let admin_quorum = calc_initial_quorum(input.users.len() as u16, input.quorum); |
|
What happens if the init args contain the same UUID multiple times? I'm not sure if the code checks for duplicate UUIDs in the input. |
Co-authored-by: mraszyk <31483726+mraszyk@users.noreply.github.com>
Co-authored-by: mraszyk <31483726+mraszyk@users.noreply.github.com>
Co-authored-by: mraszyk <31483726+mraszyk@users.noreply.github.com>
Co-authored-by: mraszyk <31483726+mraszyk@users.noreply.github.com>
Co-authored-by: mraszyk <31483726+mraszyk@users.noreply.github.com>
Co-authored-by: mraszyk <31483726+mraszyk@users.noreply.github.com>
Since the service layer is used for initial entry creation, it's up to the validation implemented there. Thanks for pointing this out, because the newly added |
Co-authored-by: mraszyk <31483726+mraszyk@users.noreply.github.com>
No description provided.