Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract canister configuration from dfx.json into separate files per canister #636

Closed
6 tasks
ericswanson-dfinity opened this issue May 14, 2020 · 2 comments
Closed
6 tasks
Assignees
Milestone

Comments

@ericswanson-dfinity
Copy link
Member

ericswanson-dfinity commented May 14, 2020

Right now, dfx.json contains a top-level canisters object which defines the configuration of all canisters.

As canisters are added, this will concentrates a lot of configuration in one file. Also, this affords the opportunity to reduce some duplication of project names and directory paths.

We'll extract the per-canister configuration into separate files, referenced by dfx.json.

Design is now here: #889

Incomplete list of parts:

  • Remove dfx config
  • Read canister definitions either inline in dfx.json or from separate files
  • When reading from separate files, make relative paths relative to canister.json location
  • Make sure all paths are underneath dfx.json parent
  • Decide if dfx new should generate files in inline or separate format
  • Decide what to do about webpack
@ericswanson-dfinity ericswanson-dfinity self-assigned this May 14, 2020
@kritzcreek
Copy link
Contributor

Please ping me when this is about to land so I can make sure to update the VSCode plugin to chase down those configuration files. Thanks!

@p-shahi
Copy link
Contributor

p-shahi commented Feb 16, 2021

decided not to do this #889

@p-shahi p-shahi closed this as completed Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants