Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend-canister): add validation methods for SNS #2958

Merged
merged 4 commits into from
Feb 8, 2023
Merged

Conversation

ericswanson-dfinity
Copy link
Member

Description

The SNS needs to call a validation method with the same parameters that it will later call to execute a proposal. This PR adds validate_grant_permission and validate_revoke_permission.

How Has This Been Tested?

Added an e2e test

@ericswanson-dfinity ericswanson-dfinity requested a review from a team as a code owner February 8, 2023 19:47
@mergify mergify bot merged commit 5a9fb7b into master Feb 8, 2023
@mergify mergify bot deleted the validation branch February 8, 2023 23:01
@mergify mergify bot removed the automerge-squash label Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants