fix: motoko canisters can import other canisters with service constructor #3138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related PR on the Motoko side: dfinity/motoko#3990 |
ericswanson-dfinity
approved these changes
May 25, 2023
mergify bot
pushed a commit
to dfinity/motoko
that referenced
this pull request
Jun 22, 2023
…ng the service arguments. (#4041) Allow canister imports of service constructors, silently ignoring the service arguments. A hack that fixes #3990 (for some definition of fix) and duplicate #2319. Really, dfx should be feeding the idl of the instantiated service, not service constructor, to dependent canisters, but until it's fixed to do so (and it hasn't been forever now), this is a reasonable and simple workaround, avoiding the error-prone and kludgy workaround of rewriting candid files described, for instance, here: https://dfinityorg.notion.site/ckBTC-example-Encode-Hackathon-0aaf6292e3404dabb49df5d1b5abc797#08a7469beaf14d6ba35e8827e363e160 and also used here: https://github.com/letmejustputthishere/ckbtc-payments via npm scripting hacks (!). Also see here for the pain this caused: https://forum.dfinity.org/t/confusing-type-error-when-crossing-canisters-expression-of-type-mytype-cannot-produce-expected-type-mytype-1/20636 UPDATE: I turned the previous error into a warning to nag us to fix dfx. UPDATE: Potentially obviated by dfinity/sdk#3138, which teaches dfx to strip the service argument. UPDATE: @chenyan-dfinity thinks we should still merge for other scenarios (old dfx, new compiler, I guess).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes SDK-1084
How Has This Been Tested?
The onchain part of the
depse2e testChecklist: