fix: Use dunce crate to get non-UNC paths when calling canonicalize #3502
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Call
dunce::canonicalize
rather thanPath::canonicalize
. On Linux/Macos, this just callsstd::fs::canonicalize()
, so no change there.PathBuf::canonicalize on Windows generally returns Windows NT UNC paths like
\\?\C:\Users\you\
. Lots of programs, including Microsoft's, don't work with these kinds of paths. For example,npm
will print out a message something likeThe current working directory is a UNC path. I'm going to use C:\Windows instead.
.dunce:
rust-lang/rust#42869 (comment)
Part of https://dfinity.atlassian.net/browse/SDK-1343
How Has This Been Tested?
Covered by existing tests on Linux/Macos.
Checklist:
I didn't put anything in the changelog because we don't release for Windows and there is no behavior change on Linux/Macos.