Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): audit #3673

Merged
merged 1 commit into from
Mar 22, 2024
Merged

fix(ci): audit #3673

merged 1 commit into from
Mar 22, 2024

Conversation

lwshang
Copy link
Contributor

@lwshang lwshang commented Mar 22, 2024 •
edited
Loading

Description

The audit action doesn't build cargo-audit with --locked which caused our recent audit jobs failure.

I created the PR to fix the action.

This PR on our side prove that the fix works.

How Has This Been Tested?

The Audit CI job should pass now.

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@lwshang lwshang marked this pull request as ready for review March 22, 2024 22:48
@lwshang lwshang requested review from chenyan-dfinity and a team as code owners March 22, 2024 22:48
@lwshang lwshang merged commit 9d8f17e into master Mar 22, 2024
35 checks passed
@lwshang lwshang deleted the lwshang/fix_audit_with_fork branch March 22, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericswanson-dfinity ericswanson-dfinity ericswanson-dfinity approved these changes

@chenyan-dfinity chenyan-dfinity Awaiting requested review from chenyan-dfinity

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lwshang @ericswanson-dfinity