-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update agent to dac18df and add wasm_memory_limit
support
#3727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamspofford-dfinity
requested review from
chenyan-dfinity and
a team
as code owners
April 25, 2024 14:17
lwshang
reviewed
Apr 25, 2024
ericswanson-dfinity
requested changes
Apr 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e2e
lwshang
reviewed
Apr 25, 2024
lwshang
requested changes
Apr 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions:
- Rename the PR title. It is far beyond upgrade agent-rs dependency.
- Add tests
adamspofford-dfinity
changed the title
feat: Update agent to dac18df939dd7e63295083a2a9b2d024cb9b0c71
feat: Update agent to dac18df and add Apr 25, 2024
wasm_memory_limit
support
lwshang
reviewed
Apr 26, 2024
lwshang
reviewed
Apr 26, 2024
lwshang
approved these changes
Apr 26, 2024
ericswanson-dfinity
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes the new
wasm_memory_limit
canister setting.