Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update agent to dac18df and add wasm_memory_limit support #3727

Merged
merged 7 commits into from
Apr 26, 2024

Conversation

adamspofford-dfinity
Copy link
Contributor

Includes the new wasm_memory_limit canister setting.

@adamspofford-dfinity adamspofford-dfinity marked this pull request as ready for review April 25, 2024 14:17
Copy link
Member

@ericswanson-dfinity ericswanson-dfinity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e2e

Copy link
Contributor

@lwshang lwshang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions:

  1. Rename the PR title. It is far beyond upgrade agent-rs dependency.
  2. Add tests

@adamspofford-dfinity adamspofford-dfinity changed the title feat: Update agent to dac18df939dd7e63295083a2a9b2d024cb9b0c71 feat: Update agent to dac18df and add wasm_memory_limit support Apr 25, 2024
@lwshang lwshang self-requested a review April 26, 2024 17:13
@adamspofford-dfinity adamspofford-dfinity merged commit c2869d8 into master Apr 26, 2024
179 checks passed
@adamspofford-dfinity adamspofford-dfinity deleted the spofford/agent-dac18df branch April 26, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants