feat: dfx start doesn't require --clean when changing replica versions or options #3777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
checkpoint checkpoint checkpoint checkpoint clippy, cleanup
ericswanson-dfinity
requested review from
chenyan-dfinity and
a team
as code owners
sesi200
approved these changes
May 31, 2024
auto-merge was automatically disabled
May 31, 2024 14:58
Pull Request is not mergeable
auto-merge was automatically disabled
May 31, 2024 17:16
Pull Request is not mergeable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For the shared local network, dfx now stores replica state in a subdirectory, where the subdirectory name is a hash of the replica version and options. This means it will no longer be necessary to pass
--cleanwhen switching between dfx versions.dfx will still reset canister ids when it detects that the local network has changed. But it will now be possible to do something like work with projects A, B, and C with dfx 0.22.0, and projects E and F with dfx 0.23.0, with
dfx +0.22.0 start/dfx +0.23.0 start, without--clean, in between them.Fixes https://dfinity.atlassian.net/browse/SDK-1638
How Has This Been Tested?
Added e2e tests
Checklist: