feat: update agent and add log_visibility support #3782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericswanson-dfinity
requested changes
Jun 6, 2024
| @@ -337,4 +338,5 @@ teardown() { | |||
| assert_contains 'Reserved cycles limit: 1_000_000_000_000' | |||
| assert_contains 'Wasm memory limit: 1_073_741_824' | |||
| assert_contains 'Freezing threshold: 604_800' | |||
| assert_contains 'Log visibility: public' | |||
There was a problem hiding this comment.
Can we update an existing test to show that dfx by default creates canister with controllers log visibility?
src/dfx-core/src/error/dfx_config.rs
Outdated
Comment on lines
63
to
64
| #[error("Failed to get log visibility for canister '{0}': {1}")] | ||
| GetLogVisibilityFailed(String, GetCanisterConfigError), |
There was a problem hiding this comment.
Suggested change
| #[error("Failed to get log visibility for canister '{0}': {1}")] | |
| GetLogVisibilityFailed(String, GetCanisterConfigError), | |
| #[error("Failed to get log visibility for canister '{0}'")] | |
| GetLogVisibilityFailed(String, #[source] GetCanisterConfigError), |
There was a problem hiding this comment.
I see GetWasmMemoryLimitError has the same problem, but the others follow this pattern
Co-authored-by: Eric Swanson <64809312+ericswanson-dfinity@users.noreply.github.com>
ericswanson-dfinity
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates
ic-agentand related crates to 0.36.0 and adds support for the canister settinglog_visibility.Fixes SDK-1543
How Has This Been Tested?
Added e2e
Checklist: