Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: generate extension manifest schema #3806

Merged
merged 2 commits into from
Jun 25, 2024
Merged

feat: generate extension manifest schema #3806

merged 2 commits into from
Jun 25, 2024

Conversation

ericswanson-dfinity
Copy link
Member

Description

dfx schema --for extension-manifest now generates the JSON schema for extension.json files.

How Has This Been Tested?

Updated CI workflow

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@ericswanson-dfinity ericswanson-dfinity marked this pull request as ready for review June 25, 2024 22:25
@ericswanson-dfinity ericswanson-dfinity requested a review from a team as a code owner June 25, 2024 22:25
@ericswanson-dfinity ericswanson-dfinity marked this pull request as draft June 25, 2024 22:29
@ericswanson-dfinity ericswanson-dfinity marked this pull request as ready for review June 25, 2024 23:01
@ericswanson-dfinity ericswanson-dfinity merged commit e7b89d7 into master Jun 25, 2024
289 checks passed
@ericswanson-dfinity ericswanson-dfinity deleted the ens/dfx-schema-for-extension-manifest branch June 25, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lwshang lwshang lwshang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericswanson-dfinity @lwshang