Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add context to dfx cache installation message #3812

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

ericswanson-dfinity
Copy link
Member

Description

When dfx runs for the first time, it installs binaries, including itself, to the dfx cache. It also displays a message that it has done so. Without context, this message can be confusing.

Changed the final message to include context about what (dfx) it's installing and where (the cache)

How Has This Been Tested?

before

$ dfx extension install nns --version 0.3.1
  Version v0.21.0-beta.0+rev12.ecf712721 installed successfully.
  Extension 'nns' installed successfully

after

$ dfx extension install nns --version 0.3.1
  Installed dfx 0.21.0-beta.0+rev12.ecf712721 to cache.
  Extension 'nns' installed successfully

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@ericswanson-dfinity ericswanson-dfinity requested a review from a team as a code owner June 28, 2024 17:37
@ericswanson-dfinity ericswanson-dfinity enabled auto-merge (squash) June 28, 2024 18:38
@ericswanson-dfinity ericswanson-dfinity merged commit 416959b into master Jun 28, 2024
288 checks passed
@ericswanson-dfinity ericswanson-dfinity deleted the ens/dfx-cache-install-context branch June 28, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants