feat: Support wasm_memory_persistence for canister upgrades
#3890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luc-blaeser
force-pushed
the
luc/wasm-memory-persistence
branch
from
03f79c7 to
cf7f089
Compare
luc-blaeser
commented
Aug 26, 2024
adamspofford-dfinity
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support Motoko enhanced orthogonal persistence (dfinity/motoko#4488) with the canister upgrade option
wasm_memory_persistence:Keepthe main memory.Noneas default mode.The support of enhanced orthogonal persistence is identified by the presence of the Wasm metadata section "enhanced-orthogonal-persistence".
NB.
Replaceis not recommended to be used aswasm_memory_persistenceas it skips the IC safety check on orthogonal persistence.How Has This Been Tested?
e2e test
wasm_memory_persistenceManually with Motoko EOP.
Checklist: