feat(asset-canister): upload and commit in same message #3954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! Time reduced from 4.8s to 2.4s! Note to myself, |
adamspofford-dfinity
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SetAssetContentArgumentshas a new fieldasset_content: opt blobwhich can be used instead ofchunk_idsso that small assets can be uploaded as part ofcommit_batch,skipping the need to await a separate
create_chunkcall.No need to bump api version again since we didn't release an asset canister between the last bump and now.
How Has This Been Tested?
Covered by existing e2e
Checklist: