fix(sdk): Asset evidence computation reproducibility fix #3958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue with non-reproducibility with regards to asset uploading.
When using
zlib-ngbackend offlate2, we have the problem that the gzip archives generated on x86 and ARM are not the same.Since we hash those archives into the
evidencewhen doing an asset upload, this creates a different evidence string when running from x86 vs. ARM.This PR removes the
zlib-ngfeature fromflate2altogether. The speedup provided byzlib-ngis not noticeable given that our assets are on the order of megabytes.How Has This Been Tested?
This branch has been used inside
dfx-orbitfor a while now, and it fixed the issue.Checklist: