Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(frontend-canister): allow setting permissions in init args #3965

Merged
merged 5 commits into from
Oct 28, 2024
Merged

feat(frontend-canister): allow setting permissions in init args #3965

merged 5 commits into from
Oct 28, 2024

Conversation

sesi200
Copy link
Contributor

@sesi200 sesi200 commented Oct 28, 2024 •
edited
Loading

Description

It is possible to overwrite the permissions lists in the asset canister's upgrade arguments, but not in init args. This PR allows setting the permissions lists in init args as well

How Has This Been Tested?

Added e2e

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@sesi200 sesi200 marked this pull request as ready for review October 28, 2024 10:32
@sesi200 sesi200 requested a review from a team as a code owner October 28, 2024 10:32
@sesi200 sesi200 enabled auto-merge (squash) October 28, 2024 10:32
@sesi200 sesi200 merged commit abab449 into master Oct 28, 2024
298 of 299 checks passed
@sesi200 sesi200 deleted the severin/allow-setting-permissions-in-init branch October 28, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lwshang lwshang lwshang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sesi200 @lwshang