fix: add browser warning message #4048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't like the implication that Safari is an unsupported browser - that would spook me as a developer |
|
@krpeacock I mean, it's not an implication, it's straightforwardly true. An unadorned 'try switching browsers' would just lead to bug reports about it. |
|
It's not nuanced enough. There is no reason that Safari shouldn't work in production, and a developer seeing this message in their starter template would believe that the Internet Computer is incompatible with Safari, which makes the platform a non-starter |
krpeacock
requested changes
Dec 20, 2024
krpeacock
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a hidden div to frontend templates to display a message suggesting switching browsers when the page breaks, to solve the Safari problem in a different way from #4011. When documentation is written on browser breakage this message should be updated to link to it.