Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include dfx version in update PR title #294

Merged
merged 3 commits into from
Dec 8, 2023
Merged

Include dfx version in update PR title #294

merged 3 commits into from
Dec 8, 2023

Conversation

dskloetd
Copy link
Collaborator

@dskloetd dskloetd commented Dec 8, 2023 •
edited
Loading

Motivation

convenience

Changes

  1. Include the new dfx version in the automated update PR title and commit message.
  2. Drive-by: Use branch-suffix as we do in nns-dapp update workflows as well.

Tested:

Created this PR with the workflow: #293

@dskloetd dskloetd requested a review from lmuntaner December 8, 2023 07:19
@dskloetd dskloetd marked this pull request as ready for review December 8, 2023 07:19
@dskloetd dskloetd requested a review from a team as a code owner December 8, 2023 07:19
@bitdivine bitdivine merged commit 49eef81 into main Dec 8, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bitdivine bitdivine bitdivine approved these changes

@lmuntaner lmuntaner Awaiting requested review from lmuntaner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dskloetd @bitdivine