Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create wallet canisters sequentially #419

Merged
merged 7 commits into from
Nov 4, 2024
Merged

Create wallet canisters sequentially #419

merged 7 commits into from
Nov 4, 2024

Conversation

dskloetd
Copy link
Collaborator

@dskloetd dskloetd commented Nov 4, 2024

Motivation

Since dfx 0.24.1, creating the snapshot results in creating only 11 or 10 SNSes instead of 12 almost every time.
For example: https://github.com/dfinity/snsdemo/actions/runs/11659664378/job/32460602932?pr=418

After debugging, I found out that creating wallet canisters as part of the parallel SNS creation started occasionally failing with.

Error: Failed to setup wallet caller.
Caused by: Failed to create wallet
Caused by: Failed to load wallet configuration
Caused by: failed to parse contents of /home/runner/work/snsdemo/snsdemo/users/snsdemo_1/.local/share/dfx/network/local/wallets.json as json
Caused by: EOF while parsing a value at line 1 column 0

I'm not sure why but it might not work well anymore to create many wallet canisters simultaneously.

Also, while I was debugging this it appears that MacOS-12 stopped being supported on GitHub.

Changes

  1. Move the creating the snsdemo identities (which includes wallet canister creation) outside the parallel process so that it is done sequentially.
  2. Check that we have the expected number of SNSes after SNS creation is done.
  3. Use MacOS 14 instead of MacOS 12.

@dskloetd dskloetd changed the title Check SNS-W for SNSes Create wallet canister sequentially Nov 4, 2024
@dskloetd dskloetd changed the title Create wallet canister sequentially Create wallet canisters sequentially Nov 4, 2024
@dskloetd dskloetd marked this pull request as ready for review November 4, 2024 15:29
@dskloetd dskloetd requested a review from a team as a code owner November 4, 2024 15:29
@dskloetd dskloetd enabled auto-merge (squash) November 4, 2024 15:29
Copy link
Contributor

@mstrasinskis mstrasinskis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dskloetd dskloetd merged commit 80c1f4f into main Nov 4, 2024
15 checks passed
@dskloetd dskloetd deleted the kloet/11-sns branch November 4, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants