Create wallet canisters sequentially #419
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Since
dfx
0.24.1, creating the snapshot results in creating only 11 or 10 SNSes instead of 12 almost every time.For example: https://github.com/dfinity/snsdemo/actions/runs/11659664378/job/32460602932?pr=418
After debugging, I found out that creating wallet canisters as part of the parallel SNS creation started occasionally failing with.
I'm not sure why but it might not work well anymore to create many wallet canisters simultaneously.
Also, while I was debugging this it appears that MacOS-12 stopped being supported on GitHub.
Changes