Update IC commit #437
Closed
Update IC commit #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pr-automation-bot-public[bot]](https://avatars.githubusercontent.com/u/59101585?s=60&v=4){kind=small}
pr-automation-bot-public
bot
force-pushed
the
bot-ic-update
branch
from
a6993c1 to
fccf3aa
Compare
dskloetd
added a commit
that referenced
this pull request
Jan 3, 2025
# Motivation [Updating the IC commit](#437) [failed](https://github.com/dfinity/snsdemo/actions/runs/12541516365/job/34970180020?pr=437) with ``` Error: Failed while trying to deploy canisters. Caused by: Failed while trying to install all canisters. Caused by: Failed to install wasm module to canister 'ckbtc_kyt'. Caused by: Failed to create argument blob. Caused by: Invalid data: Unable to serialize Candid values: Invalid data: Unable to serialize Candid values: record field num_subnet_nodes not found ``` because dfinity/ic#3056 added a new required field in the init arguments of the bitcoin checker. # Changes 1. Update the pinned IC commit hash. 2. Provide `num_subnet_nodes` in the install args of the KYT/checker canister. # Tested Creating a snapshot fails after updating the IC commit hash but works again after specifying the `num_subnet_nodes`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated changes by create-pull-request GitHub action