Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: BTreeMap V2 (beta) #115

Merged
merged 8 commits into from
Sep 5, 2023
Merged

feat: BTreeMap V2 (beta) #115

merged 8 commits into from
Sep 5, 2023

Commits on Aug 22, 2023

  1. feat: BTreeMap v2 beta

    @ielashi
    ielashi committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    fc214cd View commit details
    Browse the repository at this point in the history

  2. update tests

    @ielashi
    ielashi committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    022eaa0 View commit details
    Browse the repository at this point in the history

  3. docs

    @ielashi
    ielashi committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    12e300b View commit details
    Browse the repository at this point in the history

  4. .

    @ielashi
    ielashi committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    5af65b2 View commit details
    Browse the repository at this point in the history

  5. .

    @ielashi
    ielashi committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    8620b4f View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2023

  1. fix: init_v2 BTreeMap::new (#117) 

    Hi @ielashi,

I'm not sure but, is it possible that the init of a new `BTreeMap::new`
in `init_v2` is incorrect in your PR and should be replaced with
`BTreeMap::new_v2`?

At least, while testing your PR, I was facing following error which
seems to be resolved by tweaking those.

> 2023-08-26 14:42:36.677876 UTC: [Canister by6od-j4aaa-aaaaa-qaadq-cai]
Panicked at 'Cannot get max size of unbounded type.',
/Users/daviddalbusco/.cargo/git/checkouts/stable-structures-10185dfe005f3b12/8620b4f/src/storable.rs:450:9
    @peterpeterparker
    peterpeterparker authored Aug 28, 2023
    Configuration menu
    Copy the full SHA
    9fd6532 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2023

  1. .

    @ielashi
    ielashi committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    f781a92 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'ielashi/btree_v2' of github.com:dfinity/stable-structur… 

    …es into ielashi/btree_v2
    @ielashi
    ielashi committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    a2a15f8 View commit details
    Browse the repository at this point in the history