Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add config file for benchmarks #174

Merged
merged 4 commits into from
Jan 17, 2024
Merged

refactor: add config file for benchmarks #174

merged 4 commits into from
Jan 17, 2024

Conversation

ielashi
Copy link
Contributor

@ielashi ielashi commented Jan 17, 2024

This PR is another step towards transforming our benchmarking logic into a general-purpose tool that others can use.

Rather than hard-coding everything in benchmark.rs, the configuration is moved into a config file called bench.yml.

The eventual goal is to evolve the current benchmarking work into a tool that works like this:

  1. User defines a configuration file (e.g. bench.yml)
  2. User installs our benchmarking tool (e.g. cargo install canbench)
  3. User can now run benchmarks using cargo (e.g. cargo canbench)

Note that users won't need to write any code and the file benchmark.rs will soon be completely removed.

@ielashi ielashi requested a review from a team as a code owner January 17, 2024 13:21
Copy link

@AlexandraZapuc AlexandraZapuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@ielashi ielashi merged commit 0be1270 into main Jan 17, 2024
7 checks passed
@ielashi ielashi deleted the ielashi/bench_cfg branch January 17, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants