Proposed fix for title errorbars/quantiles bug #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhmatthews
changed the title
for more information, see https://pre-commit.ci
This was
linked to
issues
Feb 22, 2022
|
Thanks @jhmatthews! I made some minor tweaks to the error handling and updated the tests, but I think it looks good to go now. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposed fix for issues #94 #107 - which is a potentially fairly serious bug, where, if you supply the quantiles via the quantiles kwarg, the title_quantiles do not match those drawn. Instead, they are hardwired to 68% values.
This proposed fix introduces a new kwarg title_quantiles. This is a list of 3 fractional quantiles to show as the the upper and lower errors. If
None(default), it inherits the values from quantiles, unless quantiles isNone, in which case it defaults to[0.16,0.5,0.84].The test of this is currently minimal - it simply checks the default behaviour (I'm not that familiar with using @image_comparison or corner, so happy to change this). The docstring is updated but it's possible other docs are needed.
Would be grateful if someone could look this over and check the proposal looks reasonable.