Added ability to opt back in

[Aaron1011]

No description provided.

[bsdlp]

How about explicit opt-in via starring the repo? https://github.com/resume/resume.github.com/blob/master/js/githubresume.js#L112

[Aaron1011]

@dfm: Does this look good to merge?

[Aaron1011]

@dfm: Ping

[Aaron1011]

@dfm: Ping

[Aaron1011]

@dfm: Ping

[ilystsov]

I've switched to using random.choices which can generate the list of characters in one call rather than iterating with a list comprehension.
I used an f-string to format the auth_url
Instead of just urllib.urlencode, I've used urllib.parse.urlencode. This is the more modern way of importing it, especially if you're using Python 3.
I used a more conventional way to define the dictionary params.

[ilystsov]

Suggested change

	def opt_in_login(username):
	state = "".join([random.choice(string.ascii_uppercase + string.digits)
	for x in range(24)])
	flask.session["state"] = state
	params = dict(
	client_id=flask.current_app.config["GITHUB_ID"],
	redirect_uri=flask.url_for(".opt_in_callback", username=username,
	_external=True),
	state=state,
	)
	return flask.redirect("https://github.com/login/oauth/authorize?{0}"
	.format(urllib.urlencode(params)))
	def opt_in_login(username):
	state = ''.join(random.choices(string.ascii_uppercase + string.digits, k=24))
	flask.session["state"] = state
	params = {
	'client_id': flask.current_app.config["GITHUB_ID"],
	'redirect_uri': flask.url_for('.opt_in_callback', username=username, _external=True),
	'state': state,
	}
	auth_url = f"https://github.com/login/oauth/authorize?{urllib.parse.urlencode(params)}"
	return flask.redirect(auth_url)