Fix long label made of profile names

Fix GoogleContainerTools#3277 Signed-off-by: David Gageot <david@gageot.net>
dgageot · Nov 21, 2019 · 4830837 · 4830837
1 parent debaab9
commit 4830837
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 1 deletion.
diff --git a/pkg/skaffold/config/options.go b/pkg/skaffold/config/options.go
@@ -82,7 +82,14 @@ func (opts *SkaffoldOptions) Labels() map[string]string {
 		labels["skaffold.dev/namespace"] = opts.Namespace
 	}
 	if len(opts.Profiles) > 0 {
-		labels["skaffold.dev/profiles"] = strings.Join(opts.Profiles, "__")
+		profiles := strings.Join(opts.Profiles, "__")
+		if len(profiles) > 63 {
+			// k8s labels can't be more than 63 characters
+			// and must end with an alphanumeric character.
+			profiles = profiles[0:62] + "z"
+		}
+
+		labels["skaffold.dev/profiles"] = profiles
 	}
 	for _, cl := range opts.CustomLabels {
 		l := strings.SplitN(cl, "=", 2)
@@ -92,6 +99,7 @@ func (opts *SkaffoldOptions) Labels() map[string]string {
 		}
 		labels[l[0]] = l[1]
 	}
+
 	return labels
 }
 

diff --git a/pkg/skaffold/config/options_test.go b/pkg/skaffold/config/options_test.go
@@ -62,6 +62,19 @@ func TestLabels(t *testing.T) {
 				"skaffold.dev/profiles": "profile1__profile2",
 			},
 		},
+		{
+			description: "lots of profiles",
+			options: SkaffoldOptions{Profiles: []string{
+				"long_profile_name_1",
+				"long_profile_name_2",
+				"long_profile_name_3",
+				"long_profile_name_4",
+				"long_profile_name_5",
+			}},
+			expectedLabels: map[string]string{
+				"skaffold.dev/profiles": "long_profile_name_1__long_profile_name_2__long_profile_name_3_z",
+			},
+		},
 		{
 			description: "tail",
 			options:     SkaffoldOptions{Tail: true},