Skip to content

Commit

Permalink
Bumps @aspect_rules_js to latest version (1.23.0).
Browse files Browse the repository at this point in the history
Ran into one unexpected breakage and needed to set `use_execroot_entry_point = False` to keep `web_resources_devserver()` working in a test context.

See: aspect-build/rules_js#929 (comment).
  • Loading branch information
dgp1130 committed Mar 18, 2023
1 parent 5e97d86 commit 1ab5c34
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 6 deletions.
6 changes: 3 additions & 3 deletions dependencies.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@ def rules_prerender_dependencies():
maybe(
http_archive,
name = "aspect_rules_js",
sha256 = "3ad6684d744ebbc6592d404cc3aa81d0da634eccb3499f6fd198ae122fa28489",
strip_prefix = "rules_js-1.19.0",
url = "https://github.com/aspect-build/rules_js/releases/download/v1.19.0/rules_js-v1.19.0.tar.gz",
sha256 = "00e7b97b696af63812df0ca9e9dbd18579f3edd3ab9a56f227238b8405e4051c",
strip_prefix = "rules_js-1.23.0",
url = "https://github.com/aspect-build/rules_js/releases/download/v1.23.0/rules_js-v1.23.0.tar.gz",
)

maybe(
Expand Down
6 changes: 3 additions & 3 deletions examples/external/WORKSPACE.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@ register_jq_toolchains()

http_archive(
name = "aspect_rules_js",
sha256 = "3ad6684d744ebbc6592d404cc3aa81d0da634eccb3499f6fd198ae122fa28489",
strip_prefix = "rules_js-1.19.0",
url = "https://github.com/aspect-build/rules_js/releases/download/v1.19.0/rules_js-v1.19.0.tar.gz",
sha256 = "00e7b97b696af63812df0ca9e9dbd18579f3edd3ab9a56f227238b8405e4051c",
strip_prefix = "rules_js-1.23.0",
url = "https://github.com/aspect-build/rules_js/releases/download/v1.23.0/rules_js-v1.23.0.tar.gz",
)
load("@aspect_rules_js//js:repositories.bzl", "rules_js_dependencies")
rules_js_dependencies()
Expand Down
1 change: 1 addition & 0 deletions packages/rules_prerender/web_resources_devserver.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ def web_resources_devserver(
data = [resources],
testonly = testonly,
visibility = visibility,
use_execroot_entry_point = False,
tags = tags,
)

Expand Down

0 comments on commit 1ab5c34

Please sign in to comment.