Add read-only and truncate options in info tool #1037
Conversation
ashish-goswami
requested review from
jarifibrahim and
manishrjain
as code owners
![pullrequest[bot]](https://avatars.githubusercontent.com/in/3434?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ A review job has been created and sent to the PullRequest network.
@ashish-goswami you can click here to see the review status or cancel the code review job.
jarifibrahim
left a comment
jarifibrahim
left a comment
There was a problem hiding this comment.
LGTM but we'll also need to add truncate flag also. We can add it to the same PR or create a new one.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @manishrjain)
There was a problem hiding this comment.
Good refactoring to leverage this feature more widely.
Only minor thing to consider is that if there are going to be more options, consider having the descriptions defined in a constant file instead of having them spill over lines and having to be concatenated manually.
Reviewed with ❤️ by PullRequest
jarifibrahim
left a comment
jarifibrahim
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status:
danielmai
changed the title
manishrjain
left a comment
manishrjain
left a comment
There was a problem hiding this comment.
This should be merged. It's a small enough change that @jarifibrahim 's LGTM should be sufficient.
Reviewed 1 of 1 files at r2.
Reviewable status:
(cherry picked from commit ef1e8e4)
Fixes #1025
This change is