Initialize vlog before starting compactions in db.Open #1226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If compaction is started before opening vlog, badger might crash with nil pointer error when trying to push discard stats at the end of compactions because discard stats are initialized in vlog open.
jarifibrahim
requested review from
ashish-goswami,
manishrjain and
a team
as code owners
jarifibrahim
changed the title
martinmr
approved these changes
Feb 24, 2020
There was a problem hiding this comment.
Reviewed 3 of 3 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ashish-goswami and @manishrjain)
|
@manishrjain has reviewed and approved this. |
jarifibrahim
pushed a commit
that referenced
this pull request
Mar 12, 2020
If compaction is started before opening vlog, badger might crash with nil pointer error when trying to push discard stats at the end of compactions because discard stats are initialized in vlog open. This commit fixes it. (cherry picked from commit 617ed7c)
jarifibrahim
pushed a commit
that referenced
this pull request
Mar 24, 2020
If compaction is started before opening vlog, badger might crash with nil pointer error when trying to push discard stats at the end of compactions because discard stats are initialized in vlog open. This commit fixes it. (cherry picked from commit 617ed7c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If compaction is started before opening vlog, badger might crash with
nil pointer error when trying to push discard stats at the end of
compactions because discard stats are initialized in vlog open.
Fixes #1209
This change is