-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/go package #1282
Chore/go package #1282
Conversation
@jarifibrahim I can try to test it. How I should do? |
@mmeloni A simple test would be to import badger It looks like the issue isn't fixed by your PR. I see the following error on master and your PR
|
@mmeloni can you please add some information to the PR description about why this change is necessary? My understanding of protobufs is very limited. Thank you :) |
Sure, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @mmeloni
Reviewed 1 of 1 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ashish-goswami and @manishrjain)
In order to properly include pb.proto in other .proto files
This change is