Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Set relativeURL for Netlify #1612

Merged
merged 3 commits into from
Dec 7, 2020
Merged

docs: Set relativeURL for Netlify #1612

merged 3 commits into from
Dec 7, 2020

Conversation

mbj36
Copy link
Contributor

@mbj36 mbj36 commented Dec 5, 2020

Since we are in process of moving to Netlify, we need this change for docs to work.

This change has no effect on current badger docs


This change is Reviewable

Copy link
Contributor

@danielmai danielmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's one reference left to .Site.BaseURL in load-img.html. Does that need to change as well?

Reviewed 2 of 5 files at r1.
Reviewable status: 2 of 5 files reviewed, all discussions resolved (waiting on @danielmai, @jarifibrahim, and @manishrjain)

Copy link
Contributor

@danielmai danielmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 2 of 6 files reviewed, all discussions resolved (waiting on @jarifibrahim and @manishrjain)

@danielmai danielmai changed the title relativeURL for netlify docs: Set relativeURL for Netlify Dec 7, 2020
@danielmai danielmai merged commit eaf91a1 into master Dec 7, 2020
@danielmai danielmai deleted the mbj36/netlify branch December 7, 2020 18:21
@mbj36 mbj36 restored the mbj36/netlify branch December 7, 2020 19:20
@joshua-goldstein joshua-goldstein deleted the mbj36/netlify branch October 12, 2022 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants