chore: fix lint errors #1815
Merged
chore: fix lint errors #1815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return false | ||
| } | ||
| return true | ||
| return isPresent() | ||
| } |
There was a problem hiding this comment.
@skrdgraph this will go in our presentation on linters
joshua-goldstein
requested review from
akon-dey,
gcxml,
billprovince and
skrdgraph
as code owners
skrdgraph
approved these changes
Oct 14, 2022
fredcarle
pushed a commit
to fredcarle/badger
that referenced
this pull request
Aug 1, 2023
Resolving more lint errors. We fix some basic gosimple and gofmt lint errors. We raise the lll line length to 120 (as in Dgraph repo).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Resolving more lint errors.
Solution
We fix some basic gosimple and gofmt lint errors. We raise the lll line length to 120 (as in Dgraph repo).