Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): unbreak tests on Windows (#1775) #1837

Merged
merged 2 commits into from
Dec 16, 2022
Merged

Conversation

akon-dey
Copy link

@akon-dey akon-dey commented Dec 11, 2022

Currently appveyor tests are failing in multiple places on Windows.

Original PR #1775


This change is Reviewable

Problem

Solution

Currently [appveyor
tests](https://ci.appveyor.com/project/manishrjain/badger/builds/42502297)
are failing in multiple places on Windows.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg"
height="34" align="absmiddle"
alt="Reviewable"/>](https://reviewable.io/reviews/dgraph-io/badger/1775)
<!-- Reviewable:end -->
@coveralls
Copy link

coveralls commented Dec 12, 2022

Coverage Status

Coverage decreased (-0.007%) to 60.789% when pulling 499b142 on master into a717126 on main.

@joshua-goldstein
Copy link
Contributor

@akon-dey The changes here look fine, but I had to merge the latest changes from main into master in order to resolve merge conflicts. Going forward all PR's should be rebased against main (and merged into main).

Copy link
Contributor

@joshua-goldstein joshua-goldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akon-dey Changes look fine

@joshua-goldstein joshua-goldstein merged commit fba305b into main Dec 16, 2022
joshua-goldstein pushed a commit that referenced this pull request Feb 13, 2023
Currently [appveyor
tests](https://ci.appveyor.com/project/manishrjain/badger/builds/42502297)
are failing in multiple places on Windows.

Original PR #1775

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg"
height="34" align="absmiddle"

alt="Reviewable"/>](https://reviewable.io/reviews/dgraph-io/badger/1775)
<!-- Reviewable:end -->

<!--
 Change Github PR Title

 Your title must be in the following format:
 - `topic(Area): Feature`
- `Topic` must be one of
`build|ci|docs|feat|fix|perf|refactor|chore|test`

 Sample Titles:
 - `feat(Enterprise)`: Backups can now get credentials from IAM
 - `fix(Query)`: Skipping floats that cannot be Marshalled in JSON
 - `perf: [Breaking]` json encoding is now 35% faster if SIMD is present
 - `chore`: all chores/tests will be excluded from the CHANGELOG
 -->

## Problem
 <!--
 Please add a description with these things:
 1. Explain the problem by providing a good description.
 2. If it fixes any GitHub issues, say "Fixes #GitHubIssue".
 3. If it corresponds to a Jira issue, say "Fixes DGRAPH-###".
4. If this is a breaking change, please prefix `[Breaking]` in the
title. In the description, please put a note with exactly who these
changes are breaking for.
 -->

## Solution
 <!--
 Please add a description with these things:
 1. Explain the solution to make it easier to review the PR.
2. Make it easier for the reviewer by describing complex sections with
comments.
 -->

Co-authored-by: Alexey Ivanov <SaveTheRbtz@GMail.com>
Co-authored-by: Joshua Goldstein <92491720+joshua-goldstein@users.noreply.github.com>
(cherry picked from commit fba305b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants