Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): rm upgrade #1845

Merged
merged 1 commit into from
Jan 13, 2023
Merged

fix(test): rm upgrade #1845

merged 1 commit into from
Jan 13, 2023

Conversation

skrdgraph
Copy link
Contributor

@skrdgraph skrdgraph commented Jan 13, 2023

Problem

We don't need an apt upgrade* step here. this is an overkill - plus it's causing some dependency issue on the environment layer. it's also causing a bunch of tests to fail in the installation step - https://github.com/dgraph-io/badger/actions .. we don't have a consistent baseline mostly because of the failing environment setup step.

we should have a tight pinning on our environments. operations like upgrade etc. can induce failures suddenly based on upstream changes.

issue

Solution

rm upgrade*

@coveralls
Copy link

Coverage Status

Coverage: 60.742%. Remained the same when pulling 9454c11 on skrdgraph/fix_dependency into fba305b on main.

@all-seeing-code all-seeing-code self-requested a review January 13, 2023 10:30
@all-seeing-code all-seeing-code merged commit 83298b7 into main Jan 13, 2023
@all-seeing-code all-seeing-code deleted the skrdgraph/fix_dependency branch January 13, 2023 10:30
joshua-goldstein added a commit that referenced this pull request Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants