Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alpha multi zero support #37

Merged
merged 5 commits into from
Jul 15, 2020
Merged

Conversation

darkn3rd
Copy link
Contributor

@darkn3rd darkn3rd commented Jul 11, 2020

Description

This adds the ability to create a comma separated list of multiple zeros for support dgraph versions for dgraph-io/dgraph#5116

This is forward and backwards compatible (thanks to Go template Sprig library)

  • versions less than v1.2.3 will have single dgraph-zero.0 item for alpha --zero option
  • versions equal or greater than v1.2.3 will have multiple zeros, e.g. dgraph-zero.0, dgraph-zero.1, dgraph-zero.2, up to number of zero.replicaCount specified by user

Types of tests:

  • Test: helm install dgraph-test charts/charts/dgraph
    Result: dgraph alpha --zero will have 3 zeros
  • Test helm install dgraph-test charts/charts/dgraph --set zero.replicaCount=5
    Result: dgraph alpha --zero will have 5 zeros
  • Test helm install dgraph-test charts/charts/dgraph --set image.tag=v1.2.2
    Result: dgraph alpha --zero will have 1 zero

This change is Reviewable

@darkn3rd darkn3rd requested a review from danielmai July 11, 2020 07:33
Copy link
Contributor

@danielmai danielmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Address comments and then it's good to merge.

Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @darkn3rd)


charts/dgraph/templates/alpha-statefulset.yaml, line 21 at r1 (raw file):

Comma Seperated

Create a comma-separated list of Zeros


charts/dgraph/templates/alpha-statefulset.yaml, line 25 at r1 (raw file):

supported dgraph version

supported by dgraph version


charts/dgraph/templates/alpha-statefulset.yaml, line 26 at r1 (raw file):

"< 1.2.3" 

Check for < v20.03.1 too.


charts/dgraph/templates/alpha-statefulset.yaml, line 29 at r1 (raw file):

Comman seperated List Zeros

Create a comma-separated list of Zeros

Also, remove trailing whitespace.

Copy link
Contributor Author

@darkn3rd darkn3rd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 2 files reviewed, 4 unresolved discussions (waiting on @danielmai)


charts/dgraph/templates/alpha-statefulset.yaml, line 21 at r1 (raw file):

Previously, danielmai (Daniel Mai) wrote…
Comma Seperated

Create a comma-separated list of Zeros

Done.


charts/dgraph/templates/alpha-statefulset.yaml, line 25 at r1 (raw file):

Previously, danielmai (Daniel Mai) wrote…
supported dgraph version

supported by dgraph version

Done.


charts/dgraph/templates/alpha-statefulset.yaml, line 26 at r1 (raw file):

Previously, danielmai (Daniel Mai) wrote…
"< 1.2.3" 

Check for < v20.03.1 too.

Done.


charts/dgraph/templates/alpha-statefulset.yaml, line 29 at r1 (raw file):

Previously, danielmai (Daniel Mai) wrote…
Comman seperated List Zeros

Create a comma-separated list of Zeros

Also, remove trailing whitespace.

Done.

@darkn3rd darkn3rd merged commit ef6ef90 into master Jul 15, 2020
@darkn3rd darkn3rd deleted the joaquin/alpha-multi-zero-support branch July 15, 2020 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants