Add total_ns field in Latency object #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mangalaman93
force-pushed
the
aman/total_ns
branch
from
23aee8c
to
1f7da05
Compare
pawanrawal
approved these changes
Nov 26, 2019
There was a problem hiding this comment.
Reviewable status: 0 of 2 files reviewed, all discussions resolved
|
Why is this needed? The latency numbers can be summed up on the client-side. |
|
@danielmai As you can see in the example response here dgraph-io/dgraph#4312, the sum is not equal to the total latency. In fact, we expect this because the way we calculate all the latency numbers in the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is