add OPTIONS support for /ui/keywords (#4992)

Fixes #4946.
dgraph-io · Apr 24, 2020 · a8e80f8 · a8e80f8
1 parent 19a1ad8
commit a8e80f8
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/dgraph/cmd/alpha/dashboard.go b/dgraph/cmd/alpha/dashboard.go
@@ -41,7 +41,11 @@ func homeHandler(w http.ResponseWriter, r *http.Request) {
 // Used to return a list of keywords, so that UI can show them for autocompletion.
 func keywordHandler(w http.ResponseWriter, r *http.Request) {
 	x.AddCorsHeaders(w)
-	if r.Method != "GET" {
+	if r.Method == http.MethodOptions {
+		return
+	}
+
+	if r.Method != http.MethodGet {
 		http.Error(w, x.ErrorInvalidMethod, http.StatusBadRequest)
 		return
 	}

diff --git a/dgraph/cmd/alpha/http_test.go b/dgraph/cmd/alpha/http_test.go
@@ -806,3 +806,14 @@ func TestDrainingMode(t *testing.T) {
 	setDrainingMode(t, false)
 	runRequests(false)
 }
+
+func TestOptionsForUiKeywords(t *testing.T) {
+	req, err := http.NewRequest(http.MethodOptions, fmt.Sprintf("%s/ui/keywords", addr), nil)
+	require.NoError(t, err)
+
+	client := &http.Client{}
+
+	resp, err := client.Do(req)
+	require.NoError(t, err)
+	require.True(t, resp.StatusCode >= 200 && resp.StatusCode < 300)
+}