Skip to content

Commit

Permalink
Adding more details for mutation error messages with scalar/uid type …
Browse files Browse the repository at this point in the history
…mismatch (#4317)

* Adding more details for error messages with scalar/uid type mismatch

* used %q instead of "%s"
  • Loading branch information
prashant-shahi authored Nov 26, 2019
1 parent c3c1a48 commit b5d1beb
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions worker/mutation.go
Original file line number Diff line number Diff line change
Expand Up @@ -349,10 +349,10 @@ func ValidateAndConvert(edge *pb.DirectedEdge, su *pb.SchemaUpdate) error {
return nil

case !schemaType.IsScalar() && storageType.IsScalar():
return errors.Errorf("Input for predicate %s of type uid is scalar", edge.Attr)
return errors.Errorf("Input for predicate %q of type uid is scalar. Edge: %v", edge.Attr, edge)

case schemaType.IsScalar() && !storageType.IsScalar():
return errors.Errorf("Input for predicate %s of type scalar is uid. Edge: %v", edge.Attr, edge)
return errors.Errorf("Input for predicate %q of type scalar is uid. Edge: %v", edge.Attr, edge)

// The suggested storage type matches the schema, OK!
case storageType == schemaType && schemaType != types.DefaultID:
Expand Down

0 comments on commit b5d1beb

Please sign in to comment.