Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move dgraph-converter binary as a subcommand of the dgraph binary #2624

Closed
danielmai opened this issue Oct 1, 2018 · 1 comment
Closed

Move dgraph-converter binary as a subcommand of the dgraph binary #2624

danielmai opened this issue Oct 1, 2018 · 1 comment
Assignees
@srfrog
Labels
kind/enhancement Something could be better.

Comments

@danielmai
Copy link
Contributor

(Issue related to this discuss topic: https://discuss.dgraph.io/t/location-of-binaries-after-building-from-source/3324)

The binary dgraph-converter is built when running go install -v github.com/dgraph-io/dgraph/dgraph/cmd/... This command should be built into the main dgraph binary and be accessible as a subcommand, i.e. dgraph converter.
@danielmai danielmai added the kind/enhancement Something could be better. label Oct 1, 2018
@danielmai
Copy link
Contributor Author

@srfrog Can you take this?

srfrog pushed a commit that referenced this issue Oct 5, 2018
Moved dgraph-converter binary to dgraph subcommand.
cac53c6 
Rolled the dgraph-converter into cobra/viper.
Access the command with `dgraph conv` same options.

Fixed typo with cert subcommand too.

Closes #2624
@srfrog srfrog mentioned this issue Oct 5, 2018
Merged
srfrog pushed a commit that referenced this issue Oct 5, 2018
Moved dgraph-converter binary to dgraph subcommand. (#2635)
38dd0a5 
* Moved dgraph-converter binary to dgraph subcommand.

Rolled the dgraph-converter into cobra/viper.
Access the command with `dgraph conv` same options.

Fixed typo with cert subcommand too.

Closes #2624
dna2github pushed a commit to dna2fork/dgraph that referenced this issue Jul 19, 2019
@dna2github
Moved dgraph-converter binary to dgraph subcommand. (dgraph-io#2635)
b3b9abe 
* Moved dgraph-converter binary to dgraph subcommand.

Rolled the dgraph-converter into cobra/viper.
Access the command with `dgraph conv` same options.

Fixed typo with cert subcommand too.

Closes dgraph-io#2624
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srfrog srfrog

Labels
kind/enhancement Something could be better.
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danielmai @srfrog