Moved dgraph-converter binary to dgraph subcommand. #2635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rolled the dgraph-converter into cobra/viper. Access the command with `dgraph conv` same options. Fixed typo with cert subcommand too. Closes #2624
manishrjain
approved these changes
Oct 5, 2018
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @srfrog and @danielmai)
dgraph/cmd/conv/conv.go, line 2 at r1 (raw file):
/* * Copyright 2018 Dgraph Labs, Inc.
2017-2018
srfrog
commented
Oct 5, 2018
There was a problem hiding this comment.
Reviewable status: 4 of 5 files reviewed, 1 unresolved discussion (waiting on @manishrjain and @danielmai)
dgraph/cmd/conv/conv.go, line 2 at r1 (raw file):
Previously, manishrjain (Manish R Jain) wrote…
2017-2018
Done.
dna2github
pushed a commit
to dna2fork/dgraph
that referenced
this pull request
Jul 19, 2019
* Moved dgraph-converter binary to dgraph subcommand. Rolled the dgraph-converter into cobra/viper. Access the command with `dgraph conv` same options. Fixed typo with cert subcommand too. Closes dgraph-io#2624
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rolled the dgraph-converter into cobra/viper.
Access the command with
dgraph convwith same options.Fixed typo with cert subcommand too.
Closes #2624
This change is