Fix how enconding_ns is calculated. #3692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the time taken to receive the query response is included as part of the encoding time. This PR fixes that calculation.
campoy
approved these changes
Jul 19, 2019
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @manishrjain)
|
Can you please define what the l.Transport means and the logic behind this equation? |
|
I'll add a comment in the next PR to avoid having to run teamcity tests again, but transport is the time taken from the completion of the query to receiving the response (sometimes the query is processed by a different alpha). We are doing this because while debugging another issue, we noticed that the encoding time contains the time to receive the response. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the time taken to receive the query response is included as
part of the encoding time. This PR fixes that calculation.
This change is