Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhandled pb.node expand with parent edge #3807

Closed
danielmai opened this issue Aug 13, 2019 · 2 comments
Closed

Unhandled pb.node expand with parent edge #3807

danielmai opened this issue Aug 13, 2019 · 2 comments
Assignees
Labels
area/crash Dgraph issues that cause an operation to fail, or the whole server to crash. area/querylang Issues related to the query language specification and implementation. kind/bug Something is broken. priority/P0 Critical issue that requires immediate attention. status/needs-attention This issue needs more eyes on it, more investigation might be required before accepting/rejecting it

Comments

@danielmai
Copy link
Contributor

What version of Dgraph are you using?

v1.0.16. This does NOT happen on master.

Have you tried reproducing the issue with latest release?

Yes (v1.0.16)

Steps to reproduce the issue (command/config used to run Dgraph).

  1. Run Dgraph cluster running v1.0.16
  2. Set schema:
name: string @index(term) .
age: int .
friend: uid .
  1. Run query and get error response:
{
  q(func: anyofterms(name, "Michael")) {
    uid
    name
    friend {
      uid
      expand(_all_)
    }
  }
}
{
  "name": "t",
  "url": "http://localhost:8080/query?debug=true",
  "errors": [
    {
      "code": "ErrorInvalidRequest",
      "message": ": Unhandled pb.node expand with parent friend"
    }
  ]
}

Remove expand(_all_) from the query and get an empty response:

{
  q(func: anyofterms(name, "Michael")) {
    uid
    name
    friend {
      uid
    }
  }
}
{
  "data": {
    "q": []
  }
}

Expected behaviour and actual result.

An empty query response should be returned instead of an error.

@danielmai danielmai added kind/bug Something is broken. area/querylang Issues related to the query language specification and implementation. labels Aug 13, 2019
@campoy campoy added this to the Dgraph v1.0.18 milestone Sep 13, 2019
@campoy campoy added priority/P0 Critical issue that requires immediate attention. area/crash Dgraph issues that cause an operation to fail, or the whole server to crash. labels Sep 13, 2019
@campoy campoy assigned danielmai and unassigned danielmai Sep 13, 2019
@campoy campoy added the status/needs-attention This issue needs more eyes on it, more investigation might be required before accepting/rejecting it label Sep 13, 2019
@campoy
Copy link
Contributor

campoy commented Oct 4, 2019

Hey, @martinmr

Since you're already working on expand, could you have a look at this one?

@martinmr
Copy link
Contributor

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/crash Dgraph issues that cause an operation to fail, or the whole server to crash. area/querylang Issues related to the query language specification and implementation. kind/bug Something is broken. priority/P0 Critical issue that requires immediate attention. status/needs-attention This issue needs more eyes on it, more investigation might be required before accepting/rejecting it
Development

No branches or pull requests

3 participants