fix: Don't allow idx flag to be set to 0 on dgraph zero #6156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahulgurnani
requested review from
manishrjain and
vvbalaji-dgraph
as code owners
parasssh
approved these changes
Aug 11, 2020
rahulgurnani
commented
Aug 11, 2020
| @@ -83,7 +83,7 @@ instances to achieve high-availability. | |||
| "addr:port of this server, so other Dgraph alphas can talk to this.") | |||
| flag.IntP("port_offset", "o", 0, | |||
| "Value added to all listening port numbers. [Grpc=5080, HTTP=6080]") | |||
| flag.Uint64("idx", 1, "Unique node index for this server.") | |||
| flag.Uint64("idx", 1, "Unique node index for this server. idx cannot be 0.") | |||
There was a problem hiding this comment.
@danielmai Shall we update the docs here https://dgraph.io/docs/deploy/single-host-setup/#run-dgraph-zero ?
rahulgurnani
force-pushed
the
rahulgurnani/bugfixes
branch
2 times, most recently
from
1a83bdc
to
eb2f95c
Compare
rahulgurnani
force-pushed
the
rahulgurnani/bugfixes
branch
from
eb2f95c
to
37c3d9d
Compare
rahulgurnani
pushed a commit
that referenced
this pull request
Aug 14, 2020
* Fix DGRAPH-2185 * Update the help message for idx flag in dgraph zero
rahulgurnani
pushed a commit
that referenced
this pull request
Aug 14, 2020
* Fix DGRAPH-2185 * Update the help message for idx flag in dgraph zero
rahulgurnani
pushed a commit
that referenced
this pull request
Aug 14, 2020
* Fix DGRAPH-2185 * Update the help message for idx flag in dgraph zero
rahulgurnani
pushed a commit
that referenced
this pull request
Aug 14, 2020
parasssh
pushed a commit
that referenced
this pull request
Aug 17, 2020
parasssh
pushed a commit
that referenced
this pull request
Aug 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DGRAPH-2185
The panic mentioned in the bug is caused when idx is set to 0. The raft library we are using etcd/raft doesn't allow ID in the raft config to be 0 as it is reserved to denote None i.e. no leader.
This change just adds this check to gracefully exit if idx is set to 0.
This change is
Docs Preview: