fix: Don't allow idx flag to be set to 0 on dgraph zero (#6156) #6191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix DGRAPH-2185 * Update the help message for idx flag in dgraph zero
parasssh
approved these changes
Aug 14, 2020
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @manishrjain and @parasssh)
jarifibrahim
approved these changes
Aug 14, 2020
NamanJain8
reviewed
Aug 14, 2020
dgraph/cmd/zero/run.go
Outdated
| @@ -185,6 +185,10 @@ func run() { | |||
| LudicrousMode: Zero.Conf.GetBool("ludicrous_mode"), | |||
| } | |||
|
|
|||
| if opts.nodeId == 0 { | |||
| log.Fatalf("ERROR: Cannot idx flag cannot be 0. Please try again with idx as a positive integer") | |||
There was a problem hiding this comment.
Can you reword the error message? @rahulgurnani
There was a problem hiding this comment.
Thanks for pointing it out!
There was a problem hiding this comment.
Fixed on master and cherry picked here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick
Fix DGRAPH-2185
Update the help message for idx flag in dgraph zero
This change is
Docs Preview: