opt(dropPrefix): do logical drop for deleting predicates and indexing #7764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohanprasad
approved these changes
May 3, 2021
jarifibrahim
reviewed
May 3, 2021
manishrjain
reviewed
May 3, 2021
There was a problem hiding this comment.
Shouldn't need to do this in Dgraph. Badger should work automatically, given an option.
Reviewable status: 0 of 8 files reviewed, all discussions resolved (waiting on @vvbalaji-dgraph)
NamanJain8
force-pushed
the
naman/drop-prefix-nb
branch
from
5f62876
to
0fbbf39
Compare
manishrjain
approved these changes
May 4, 2021
There was a problem hiding this comment.
Reviewed 7 of 7 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @vvbalaji-dgraph)
NamanJain8
force-pushed
the
naman/drop-prefix-nb
branch
from
82d4b4a
to
eb00203
Compare
NamanJain8
added a commit
that referenced
this pull request
May 5, 2021
…ing (#7764) Issue: DropPrefix is Stop The World operation. It blocks the incoming writes. Dgraph uses this API at a couple of places like: - drop data - reindexing - dropping predicate The last 2 usages can lead to bad user impact in a multi-tenant cluster. Solution: This PR allows DropPrefix to use the blocking/non-blocking DropPrefix based on DB option `AllowStopTheWorld` that can be set using `--badger` superflag. (cherry picked from commit c86b855)
NamanJain8
added a commit
that referenced
this pull request
May 5, 2021
…ing (#7764) (#7779) Issue: DropPrefix is Stop The World operation. It blocks the incoming writes. Dgraph uses this API at a couple of places like: - drop data - reindexing - dropping predicate The last 2 usages can lead to bad user impact in a multi-tenant cluster. Solution: This PR allows DropPrefix to use the blocking/non-blocking DropPrefix based on DB option `AllowStopTheWorld` that can be set using `--badger` superflag. (cherry picked from commit c86b855)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses DGRAPH-3319 and Relates to dgraph-io/badger#1698
Issue:
DropPrefixis Stop The World operation. It blocks the incoming writes. Dgraph uses this API at couple of places like:The last 2 usages can lead to bad user impact in a multi-tenant cluster.
Solution:
This PR replaces the usage of
DropPrefixwithDropPrefixNonBlocking. This API does a logical delete and does not block the writes.This change is