release-cloud: opt(dropPrefix): allow logical drop for deleting predicates and indexing (#7764) #7779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing (#7764) Issue: DropPrefix is Stop The World operation. It blocks the incoming writes. Dgraph uses this API at a couple of places like: - drop data - reindexing - dropping predicate The last 2 usages can lead to bad user impact in a multi-tenant cluster. Solution: This PR allows DropPrefix to use the blocking/non-blocking DropPrefix based on DB option `AllowStopTheWorld` that can be set using `--badger` superflag. (cherry picked from commit c86b855)
ahsanbarkati
approved these changes
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
DropPrefix is Stop The World operation. It blocks the incoming writes. Dgraph uses this API at a couple of places like:
The last 2 usages can lead to bad user impact in a multi-tenant cluster.
Solution:
This PR allows DropPrefix to use the blocking/non-blocking DropPrefix based on DB option
AllowStopTheWorldthat can be set using--badgersuperflag.(cherry picked from commit c86b855)
This change is